Add a new server with localhost handlers #2635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulyufan2
force-pushed
the
wipLocalhostServer
branch
from
efd7b95
to
2dcabad
Compare
rbtr
reviewed
Mar 6, 2024
paulyufan2
force-pushed
the
wipLocalhostServer
branch
2 times, most recently
from
44c2cf5
to
1b501f4
Compare
paulyufan2
force-pushed
the
wipLocalhostServer
branch
2 times, most recently
from
96623df
to
bda18db
Compare
|
@paulyufan2, can you update me on this? My understanding is that we’re starting two servers within CNS, with the echo one handling local requests. Can we move all localhost handlers to this new server in this PR for clarity? |
|
@nddq This PR has moved all localhost handlers to the new echo server and next PR will remove localhost handlers from restserver and start two listeners. |
nddq
approved these changes
Mar 14, 2024
tamilmani1989
approved these changes
Mar 15, 2024
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
paulyufan2
force-pushed
the
wipLocalhostServer
branch
from
bda18db
to
ca9d863
Compare
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
The AKS listeners for the CNI to talk to CNS should be on localhost
This PR is to move all handlers that should be on localhost to a echo server
Next PR will start this server, separate handlers from restserver and start two listeners
Issue Fixed:
Requirements:
Notes: