-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add azr metrics in heartbeats #2735
Conversation
It looks like this suffers from some import cycles, so it won't compile. |
b100cdf
to
4a96e92
Compare
8980541
to
72ae3ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments. Can sync offline as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments for feedback that needs to be addressed.
9eb54c3
to
135948b
Compare
f12c33a
to
f1c5107
Compare
/azp run Azure Container Networking PR |
Azure Pipelines successfully started running 1 pipeline(s). |
Reason for Change:
for Direct CNS mode, we want to add IsAZRSupported and HomeAZ as custom metrics in heartbeats, that way we know if a node has azr enabled or not.
Issue Fixed:
Requirements:
Notes: