Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport] fix/ci: Linux NPM race condition editing "except" CIDR and NPM pipeline fixes #2882

Open
wants to merge 7 commits into from

Conversation

huntergregory
Copy link
Contributor

Reason for Change:
Backporting #2841 and pipeline changes for NPM Cyclonus, Conformance, and Scale Test pipelines.

Issue Fixed:
#2840

Requirements:

Notes:

jpayne3506 and others added 7 commits July 25, 2024 14:41
ci: update cyclonus workflow
Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com>
ci: add triggers to npm pipelines
Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com>
ci: update Cyclonus triggers
Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com>
… Cyclonus/Scale (#2874)

* ci: comment out windows cyclonus and windows scale test

Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com>

* ci: slim down windows conformance to 14 tests

Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com>

* ci: make sure conformance skips "Linux Only"

Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com>

* ci: conformance was not running test cases due to formatting

Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com>

---------

Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com>
* ci: Always delete npm conformance clusters

* test: pin k8s suite version

* ci: comment out updated cyclonus

* chore: cleanup yaml

Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com>
ci: add bash directive to scale scripts

Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com>
… "except" CIDR (#2841)

* fix: syntax error when deleting nomatch CIDR ipset

Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com>

* test: ut members with nomatch

Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com>

---------

Signed-off-by: Hunter Gregory <42728408+huntergregory@users.noreply.github.com>
@huntergregory huntergregory added npm Related to NPM. ci Infra or tooling. linux labels Jul 26, 2024
@huntergregory huntergregory requested review from a team as code owners July 26, 2024 16:23
@huntergregory
Copy link
Contributor Author

/azp run Azure Container Networking PR

@huntergregory
Copy link
Contributor Author

/azp run NPM Conformance Tests

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@huntergregory
Copy link
Contributor Author

/azp run NPM Scale Test

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@QxBytes QxBytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that you're backporting multiple ci prs and a single fix which if so looks good. The linter has been failing on v1.5.x for the past few backports.

@rbtr
Copy link
Contributor

rbtr commented Jul 26, 2024

lint won't block here. just needs sign-off from @Azure/acn-npm-reviewers

@huntergregory huntergregory added this pull request to the merge queue Jul 26, 2024
Any commits made after this event will not be merged.
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 26, 2024
@huntergregory huntergregory added this pull request to the merge queue Jul 26, 2024
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Infra or tooling. linux npm Related to NPM.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants