Code changes to address review comments.

Azure · Jun 17, 2024 · 1ff1f06 · 1ff1f06
1 parent 37009ca
commit 1ff1f06
Showing 1 changed file with 7 additions and 10 deletions.
diff --git a/Microsoft.Azure.Cosmos/src/Serializer/CosmosSystemTextJsonSerializer.cs b/Microsoft.Azure.Cosmos/src/Serializer/CosmosSystemTextJsonSerializer.cs
@@ -13,7 +13,7 @@ namespace Microsoft.Azure.Cosmos
     /// <summary>
     /// This class provides a default implementation of System.Text.Json Cosmos Linq Serializer.
     /// </summary>
-    public class CosmosSystemTextJsonSerializer : CosmosLinqSerializer
+    internal class CosmosSystemTextJsonSerializer : CosmosLinqSerializer
     {
         /// <summary>
         /// A read-only instance of <see cref="JsonSerializerOptions"/>.
@@ -25,7 +25,7 @@ public class CosmosSystemTextJsonSerializer : CosmosLinqSerializer
         /// with the default values for the Cosmos SDK
         /// </summary>
         /// <param name="jsonSerializerOptions">An instance of <see cref="JsonSerializerOptions"/> containing the json serialization options.</param>
-        public CosmosSystemTextJsonSerializer(
+        internal CosmosSystemTextJsonSerializer(
             JsonSerializerOptions jsonSerializerOptions)
         {
             this.jsonSerializerOptions = jsonSerializerOptions;
@@ -37,14 +37,14 @@ public override T FromStream<T>(Stream stream)
             if (stream == null)
                 throw new ArgumentNullException(nameof(stream));
 
-            if (stream.CanSeek && stream.Length == 0)
+            if (typeof(Stream).IsAssignableFrom(typeof(T)))
             {
-                return default;
+                return (T)(object)stream;
             }
 
-            if (typeof(Stream).IsAssignableFrom(typeof(T)))
+            if (stream.CanSeek && stream.Length == 0)
             {
-                return (T)(object)stream;
+                return default;
             }
 
             using (stream)
@@ -60,10 +60,7 @@ public override Stream ToStream<T>(T input)
             MemoryStream streamPayload = new ();
             using Utf8JsonWriter writer = new (streamPayload);
 
-            JsonSerializer.Serialize(
-                writer: writer,
-                value: input,
-                options: this.jsonSerializerOptions);
+            JsonSerializer.Serialize(writer, input, this.jsonSerializerOptions);
 
             streamPayload.Position = 0;
             return streamPayload;