Add mocking constructors to TransactionalBatchOperationResult #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nged private -> protected ctor in TransactionalBatchOperationResult. This allows for Mocks, consistent with the other public classes.
abhijitpai
previously approved these changes
Nov 24, 2019
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
j82w
reviewed
Nov 25, 2019
|
|
…nsactionalBatchOperationResult<T> are mockable.
ealsur
previously approved these changes
Nov 25, 2019
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
j82w
previously approved these changes
Nov 25, 2019
kirankumarkolli
previously approved these changes
Nov 26, 2019
|
@joshlang can you please resolve conflicts? |
joshlang
dismissed stale reviews from kirankumarkolli, j82w, and ealsur
via
6b80c87
Sure. Done. I made the presumption that it'll make it into 3.5.0. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
kirankumarkolli
approved these changes
Nov 27, 2019
|
Thanks alot @joshlang for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
#1048
Mocking constructors were missing from TransactionalBatchOperationResult. Probably by accident. This pull request adds them back in.
Other public classes in this project support mocking. It's also consistent with guidance here: https://azure.github.io/azure-sdk/dotnet_introduction.html
Type of change
Closing issues
closes #1048
Assignee
Please add yourself as the assignee
Projects
Please add relevant projects so this issue can be properly tracked.