Geometry Client V3 changes #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sboshra
reviewed
Dec 12, 2019
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/IndexingPolicyTests.cs
Outdated
Show resolved
Hide resolved
j82w
reviewed
Dec 12, 2019
| //------------------------------------------------------------ | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| //------------------------------------------------------------ | ||
| namespace Microsoft.Azure.Cosmos |
There was a problem hiding this comment.
Should all these files be in?
namespace Microsoft.Azure.Cosmos.Spatial
There was a problem hiding this comment.
No, those files are serialization related files. those had a separate folder even in V2( SharedFiles\Spatial). However this PR changes the container properties(i.e. collection content), so should remain in this namespace. Its the same even in V2, these files are directly under sharedFiles.
sboshra
approved these changes
Dec 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Enabling support for spatial geometry in client
• Enabling support for creating geometry collections, and adding indexes for the same in V3. Same changes for V2 is checked in: http://codeflow/extensions/launcher.html?server=https:%2f%2fmsdata.visualstudio.com%2f&projectId=ba574a88-a171-48e0-8fcb-5fef6d23739c&reviewId=357789&projectshortname=msdata
• Geometry collection content will look like:
{
"id":"Coll1",
"indexingPolicy":{
"spatialIndexes":[
{
"path":"...",
"types":[
"Point"
],
"boundingBox":
{
"xmin":xmin,
"ymin":ymin,
"xmax":xmax,
"ymax":ymax
}
}
]
},
"geospatialConfig": {"type": "Geometry"}
}
• Added tests for creating geometry spatial index in indexingPolicy test suite
Type of change
Assignee
Please add yourself as the assignee
Projects
Please add relevant projects so this issue can be properly tracked.