Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross Partition Execution Context Refactor #1260

Merged
merged 39 commits into from
Mar 12, 2020
Merged

Cross Partition Execution Context Refactor #1260

merged 39 commits into from
Mar 12, 2020

Conversation

bchong95
Copy link
Contributor

@bchong95 bchong95 commented Mar 5, 2020

Cross Partition Execution Context Refactor

Description

Refactors Parallel and Order By execution context to be a partial class that has 4 files each:

  • Fields,
  • Drain
  • Continuation Token Logic
  • Resume

Which represent the fields + 3 stages of query execution.

I have also refactored the base class to have the same methods, just with a stronger contract.

@bchong95
realized that this will be a lot of work
a001801
@bchong95
merged
f70d18a
@bchong95
wired up continuation token on the write path
f8359f2
@bchong95
wiring continuation new continuation token in the read path
ab6bcc1
@bchong95
updated distinct and group by
a5fa91d
@bchong95
drafted out code
b50ae6d
@bchong95
merged
02e95ca
@bchong95
merged
689fe8f
@bchong95
wired in serialize state
81418d0
@bchong95
merged
658d3f7
@bchong95
fixed test cases
f4e689e
@bchong95
merged
2ced726
@bchong95
I give up
3e470e0
@bchong95
can't do it
d5ff581
@bchong95
added min max continuation token
7ebd158
@bchong95
merged
230193c
@bchong95
removed TryGetContinuationToken
20000cb
@bchong95
fixed random bugs
e76d053
@bchong95
fixed more bugs
d9455b1
@bchong95
about to gut out RequestContinuationToken and just wire through Cosmo…
ca3d0cf 
…sElement
@bchong95
made input a cosmos element
fb031f3
@bchong95
returning continuation token instead
8d8279f
@bchong95
merged
1e31ac2
@bchong95
updated tests
4fe4933
@bchong95
resolved iteration comments
abec934
@bchong95
broke up parallel execution context into different files based on stages
144364f
@bchong95
refactored parrallel resume code
26e2fc5
@bchong95
broke order by into separate files
3f65c71
@bchong95
refactored code
f0d2874
@bchong95
fixed bugs
c52f60d
ealsur
ealsur reviewed Mar 5, 2020
View reviewed changes
Microsoft.Azure.Cosmos/src/Query/Core/ContinuationTokens/CompositeContinuationToken.cs Show resolved Hide resolved
...ft.Azure.Cosmos/src/Query/Core/ExecutionContext/CosmosCrossPartitionQueryExecutionContext.cs Show resolved Hide resolved
...ft.Azure.Cosmos/src/Query/Core/ExecutionContext/CosmosCrossPartitionQueryExecutionContext.cs Outdated Show resolved Hide resolved
...ft.Azure.Cosmos/src/Query/Core/ExecutionContext/CosmosCrossPartitionQueryExecutionContext.cs Outdated Show resolved Hide resolved
...ft.Azure.Cosmos/src/Query/Core/ExecutionContext/CosmosCrossPartitionQueryExecutionContext.cs Outdated Show resolved Hide resolved
...ft.Azure.Cosmos/src/Query/Core/ExecutionContext/CosmosCrossPartitionQueryExecutionContext.cs Show resolved Hide resolved
...ry/Core/ExecutionContext/OrderBy/CosmosOrderByItemQueryExecutionContext.ContinuationToken.cs Show resolved Hide resolved
...mos/src/Query/Core/ExecutionContext/OrderBy/CosmosOrderByItemQueryExecutionContext.Resume.cs Outdated Show resolved Hide resolved
...mos/src/Query/Core/ExecutionContext/OrderBy/CosmosOrderByItemQueryExecutionContext.Resume.cs Outdated Show resolved Hide resolved
sboshra
sboshra previously approved these changes Mar 9, 2020
View reviewed changes
Copy link
Contributor

@sboshra sboshra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@bchong95 @j82w
Update Microsoft.Azure.Cosmos/src/Query/Core/ExecutionContext/OrderBy…
69d0985 
…/CosmosOrderByItemQueryExecutionContext.Resume.cs

Co-Authored-By: j82w <j82w@users.noreply.github.com>
@bchong95 bchong95 self-assigned this Mar 11, 2020
ealsur
ealsur reviewed Mar 12, 2020
View reviewed changes
Copy link
Member

@ealsur ealsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bugfix!

ealsur
ealsur previously approved these changes Mar 12, 2020
View reviewed changes
j82w
j82w previously approved these changes Mar 12, 2020
View reviewed changes
@bchong95 bchong95 dismissed stale reviews from j82w and ealsur via 8c85cae March 12, 2020 17:10
@sboshra sboshra merged commit e3e23a5 into master Mar 12, 2020
@sboshra sboshra deleted the users/brchon/Query/ExecutionContextFactoryRefactor branch March 12, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j82w j82w j82w left review comments

@sboshra sboshra sboshra approved these changes

@ealsur ealsur ealsur left review comments

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

Assignees

@bchong95 bchong95

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@bchong95 @ealsur @j82w @sboshra