Response type: Fix deadlock on scenarios with SynchronizationContext when using Response.Container

[j82w]

Pull Request Template

Description

The DatabaseResponse.Database is returning DatabaseCore instead of the correct DatabaseInlineCore. To fix this issue the type was converted to inheritance instead of composition.

Composition created a circle reference where DatabaseInlineCore needed DatabaseCore for the actual implementation, but DatabaseCore needed the DatabaseInlineCore for the response creation.

Added a new DatabaseInternal contract. The current model of using virtual makes it difficult to see what the SDK is using internally. This avoids the dangerous casting between the different types. It also prevents creating dependencies on the implementation class.

The other types will be done in a follow up PR to keep the PR to a reasonable size.

Current model

public abstract Database
internal DatabaseCore : Database
internal DatabaseInlineCore : Database

New model

public abstract Database
internal abstract DatabaseInternal : Database
internal DatabaseCore : DatabaseInternal 
internal DatabaseInlineCore : DatabaseCore 

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

[kirankumarkolli]

Out of sync with master

[kirankumarkolli]

Title is not clear on ambiguity. Suggestions?

[FabianMeiswinkel]

Thanks - looks good an will simplify our life goign forward