-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Preview] FeedRange: Add Json serialization support #1410
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/ContractTests.cs
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Serializer/FeedRange/FeedRangeInternalConverter.cs
Show resolved
Hide resolved
j82w
approved these changes
Apr 21, 2020
kirankumarkolli
approved these changes
Apr 22, 2020
ealsur
added a commit
that referenced
this pull request
Apr 22, 2020
* tojson fromjson * emulator tests * Simplifying serialization * new tests * message text * else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
FeedRange.ToJsonString
andFeedRange.FromJsonString
to accommodate scenarios where a user might want to persist a FeedRange in a storage and have worker instances picking them up and assigning them.As part of the PR, the JsonConverters involved were unified (from 3 to 1), and overall serialization simplified (there were TryParse implementations before around the FeedRange implementations).
Type of change