Query and change feed: Add serialization optimization by using array instead of by item #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 14, 2020 11:27
j82w
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Add|Fix|Refactor) Description"
Examples:
Diagnostics: Add GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fix null reference when using default(PartitionKey)
[v4] Client Encryption: Refactor code to external project
[Internal] Query: Add code generator for CosmosNumbers for easy additions in the future.
j82w
changed the title
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Add|Fix|Refactor) Description"
Examples:
Diagnostics: Add GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fix null reference when using default(PartitionKey)
[v4] Client Encryption: Refactor code to external project
[Internal] Query: Add code generator for CosmosNumbers for easy additions in the future.
This reverts commit 01e39d4.
Microsoft.Azure.Cosmos/src/Serializer/CosmosFeedResponseSerializer.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Serializer/CosmosFeedResponseSerializer.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Serializer/CosmosFeedResponseSerializer.cs
Outdated
Show resolved
Hide resolved
ealsur
previously approved these changes
May 14, 2020
Microsoft.Azure.Cosmos/src/Serializer/CosmosFeedResponseSerializer.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Performance.Tests/Program.cs
Outdated
Show resolved
Hide resolved
added 2 commits
May 14, 2020 12:55
ealsur
reviewed
May 14, 2020
ealsur
previously approved these changes
May 14, 2020
Microsoft.Azure.Cosmos/src/Serializer/CosmosFeedResponseSerializer.cs
Outdated
Show resolved
Hide resolved
...re.Cosmos/tests/Microsoft.Azure.Cosmos.Performance.Tests/CosmosElements/ReadFeedBenchmark.cs
Show resolved
Hide resolved
FabianMeiswinkel
previously approved these changes
May 15, 2020
j82w
changed the title
Microsoft.Azure.Cosmos/src/Serializer/CosmosFeedResponseSerializer.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Serializer/CosmosFeedResponseSerializer.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Serializer/CosmosFeedResponseSerializer.cs
Outdated
Show resolved
Hide resolved
added 2 commits
May 15, 2020 05:14
Microsoft.Azure.Cosmos/src/Serializer/CosmosFeedResponseSerializer.cs
Outdated
Show resolved
Hide resolved
FabianMeiswinkel
previously approved these changes
May 15, 2020
bchong95
approved these changes
May 15, 2020
ealsur
approved these changes
May 15, 2020
j82w
changed the title
kirankumarkolli
pushed a commit
that referenced
this pull request
May 16, 2020
…nstead of by item (#1516) * ReadFeed and ChangeFeed optimization. # Conflicts: # Microsoft.Azure.Cosmos/src/Serializer/CosmosElementSerializer.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This optimizes the query, read feed, and change feed serialization logic. This now sends an array to the serializer instead of serializing each item individually.
Read feed and change feed instead of using cosmos elements which has a DOM this now just searches the binary array for the start and end of the outer documents array.
This being done under the assumption that any new array being added to the service envelope will be a breaking change and will require an API version bump to correctly handle it.
Type of change
Please delete options that are not relevant.
This only includes the cost of unwrapping the service envelope and getting the array of documents that serializer can easily understand.