Transport: Fix unify HttpClient usage across Gateway classes #1548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealsur
requested review from
bchong95,
FabianMeiswinkel,
j82w,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
j82w
reviewed
May 20, 2020
j82w
reviewed
May 20, 2020
|
Turns out it's a bit more tricky, we are using the |
ealsur
changed the title
kirankumarkolli
previously approved these changes
Jun 11, 2020
j82w
approved these changes
Jul 20, 2020
fnarenji
pushed a commit
that referenced
this pull request
Oct 13, 2020
If the user was trying to use a custom HttpClientFactory to use a single HttpClient instance, it was not reaching these classes. The effect also was that we were maintaining 3 different HttpClient instances normally. This PR unifies this into a single HttpClient, that can either be created or obtained from the HttpClientFactory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1429 added support for HttpClientFactory inside the gateway connection mode, but the
DocumentClientwas maintaining two otherHttpClientinstances on GatewayAccountReader and GatewayAddressCache.If the user was trying to use a custom HttpClientFactory to use a single HttpClient instance, it was not reaching these classes.
The effect also was that we were maintaining 3 different HttpClient instances normally.
This PR unifies this into a single HttpClient, that can either be created or obtained from the
HttpClientFactory.Type of change
Please delete options that are not relevant.