Gateway Trace: Fixes a bug where the ActivityId is being set to Guid.Empty #1720
Conversation
j82w
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors) Description"
Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
j82w
changed the title
| @@ -162,10 +162,6 @@ internal static INameValueCollection ExtractResponseHeaders(HttpResponseMessage | |||
| HttpResponseMessage responseMessage, | |||
| IClientSideRequestStatistics requestStatistics) | |||
| { | |||
| // ensure there is no local ActivityId, since in Gateway mode ActivityId | |||
| // should always come from message headers | |||
| Trace.CorrelationManager.ActivityId = Guid.Empty; | |||
There was a problem hiding this comment.
Can we add a UT that checks that the ActivityId is not empty?
There was a problem hiding this comment.
Can we do a dry run with our gates to see which paths will fail?
There was a problem hiding this comment.
The debug assert that I added verifies it for all tests.
|
Looks good to me |
…Empty (#1720) * Fixed tracing activity id * Reverted unnecessary changes * Always uses the local activity id
|
Closing due to in-activity, pease feel free to re-open. |
Pull Request Template
Description
This fixes a bug where Trace.CorrelationManager.ActivityId was getting set to Guid.Empty instead of the response Activity Id. This causes any traces to have Guid.Empty instead of the correct value.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber