Diagnostics: Adds ActivityScope to operation level #1728
Conversation
j82w
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors) Description"
Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
j82w
changed the title
…ithub.com/Azure/azure-cosmos-dotnet-v3 into users/jawilley/diagnostics/sameActivityId
| }); | ||
| } | ||
|
|
||
| private async Task<TResult> RunWithDiagnosticsHelperAsync<TResult>( | ||
| CosmosDiagnosticsContext diagnosticsContext, | ||
| Func<CosmosDiagnosticsContext, Task<TResult>> task) | ||
| { | ||
| try | ||
| using (new ActivityScope(Guid.NewGuid())) |
There was a problem hiding this comment.
Caller ActivityId might be overwritten. Does it need to be conditional on non-existence?
There was a problem hiding this comment.
This seems to be by design. The activity scope save the current activity id, updates it to the new one. Once the ActivityScope is disposed it switches back to the original activity id.
…ithub.com/Azure/azure-cosmos-dotnet-v3 into users/jawilley/diagnostics/sameActivityId
|
Closing due to in-activity, pease feel free to re-open. |
Pull Request Template
Description
The activity scope is currently set at each network call. This makes it difficult to for Cosmos DB service to track a single user request across multiple retries. This will also fix issues where the Traces did not have an activity id. For query and other operation it will still be a unique activity id per a backend call. This follows the model of the Java SDK. This change seems to be caused by a miss when the retry logic moved from below the TransportHandler to above it as a RequestHandler.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber