HttpClient: Fixes HttpResponseMessage.RequestMessage is null in WASM #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealsur
requested review from
bchong95,
FabianMeiswinkel,
j82w,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
j82w
reviewed
Sep 24, 2020
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/GatewayStoreModelTest.cs
Outdated
Show resolved
Hide resolved
FabianMeiswinkel
previously approved these changes
Sep 24, 2020
…re-cosmos-dotnet-v3 into users/ealsur/gwnullref
j82w
approved these changes
Sep 25, 2020
|
Closing due to in-activity, pease feel free to re-open. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
HttpClient on WebAssembly seems to behave a bit differently than in NET Core/FX. When doing a
SendAsync, the resultingHttpResponseMessagedoes not have theRequestMessageproperty set to the originatingHttpRequestMessage.During Cache operations, if the operation fails with, for example, a 404, GatewayStoreClient will use
GatewayStoreClient.CreateDocumentClientExceptionAsyncto parse theHttpResponseMessage, and use theRequestMessageproperty to get the original Url, but this triggers aNullReferenceExceptionin WASM (see linked Issue).This PR makes sure to set the property in the
CosmosHttpClientif the property is null after callingSendAsync.Type of change
Closing issues
Closes #1873