Query: Fixes Equals method on SqlParameter class #2044
Conversation
fnbalaji
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
j82w,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors) Description"
Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
fnbalaji
changed the title
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors) Description"
Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
fnbalaji
changed the title
fnbalaji
changed the title
j82w
changed the title
j82w
changed the title
j82w
changed the title
j82w
changed the title
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/SqlParameterEqualityTests.cs
Show resolved
Hide resolved
| @@ -79,7 +79,8 @@ public bool Equals(SqlParameter other) | |||
| return true; | |||
| } | |||
|
|
|||
| return this.Name == other.Name && this.Value == other.Value; | |||
| return this.Name == other.Name | |||
| && other.Value == null ? this.Value == null : other.Value.Equals(this.Value); | |||
There was a problem hiding this comment.
This still doesn't work for arrays and object, since they don't override .Eqauls() and we need to do a deep equality here.
The long term / proper solution is to compare the JSONs for equivalency.
|
Closing due to in-activity, pease feel free to re-open. |
Pull Request Template
Description
SqlParameterEquality relies on == operator on Name and Value. While this is okay for Name since that is explictly typed as a string, it fails for value since that is typed as an object. For an object (even when it is a string) == falls to Object.ReferenceEquals, while the right thing to do is call the Equals method.
The unit tests were passing because they use literal strings, which have the same reference in testing. I have also changed the unit tests.
Type of change
Please delete options that are not relevant.
Closing issues