Internal PartitionKeyRangeCache: Adds RID refresh on NotFound in GetRoutingMapAsync #2096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnarenji
requested review from
ealsur,
FabianMeiswinkel,
j82w,
kirankumarkolli,
kirillg and
sboshra
as code owners
j82w
reviewed
Dec 28, 2020
Microsoft.Azure.Cosmos/src/Resource/Container/ContainerInternal.cs
Outdated
Show resolved
Hide resolved
fnarenji
force-pushed
the
users/flnarenj/sdk/pkrcrefresh
branch
from
1921e6d
to
397e91e
Compare
fnarenji
force-pushed
the
users/flnarenj/sdk/pkrcrefresh
branch
from
397e91e
to
957c186
Compare
fnarenji
changed the title
j82w
previously approved these changes
Dec 30, 2020
fnarenji
force-pushed
the
users/flnarenj/sdk/pkrcrefresh
branch
from
b90e9fd
to
7c343d7
Compare
j82w
approved these changes
Dec 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
In GetRoutingMapAsync, we read the RID from cache & then look up the associated collection routing map.
In the case where the RID is stale & the collection routing map is not found, the stale RID should be invalidated & the operation retried.
I am also switching a method written using ContinueWith to be async instead as I found during testing that this style can cause AggregateException to be thrown which callers do not typically expect (e.g. a NotFound would end up as a 500 because of that).
Triage source is CRI.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber