Gateway: Adds header optimization #2098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 28, 2020 09:23
j82w
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
|
What's the RPS impact? Fully materialization and optimization are two improvements. |
...e.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/FeedToken/ChangeFeedIteratorCoreTests.cs
Outdated
Show resolved
Hide resolved
added 2 commits
December 29, 2020 08:05
…Azure/azure-cosmos-dotnet-v3 into users/jawilley/perf/httpHeaders
Still running RPS for direct mode to see if there is an impact. Gateway mode RPS is described in the PR description with roughly 5.6% gain. |
ealsur
reviewed
Dec 29, 2020
| public override int Count() | ||
| { | ||
| int count = 0; | ||
| if (this.dictionaryNameValueCollection.IsValueCreated) |
added 2 commits
January 4, 2021 10:55
…Azure/azure-cosmos-dotnet-v3 into users/jawilley/perf/httpHeaders
ealsur
approved these changes
Jan 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This adds a optimized header for the gateway store model. This model wraps the existing header objects. This avoids iterating and doing string join on all the operations.
Top10AVGRps for gateway mode
Master: 11868.333333
Optimized: 12555.411765
Profiler shows it consumes %16 of CPU from code in main branch. After this PR the profiler no longer shows the conversion.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber