CosmosClientOptions and CosmosClientBuilder: Adds client level support for EnableContentResponseOnWrite #2145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asketagarwal
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
j82w,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
....Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosClientContentResponseTests.cs
Show resolved
Hide resolved
kirankumarkolli
requested changes
Jan 22, 2021
j82w
reviewed
Jan 22, 2021
Microsoft.Azure.Cosmos/src/RequestOptions/ItemRequestOptions.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Jan 22, 2021
ealsur
reviewed
Jan 22, 2021
j82w
reviewed
Jan 25, 2021
j82w
reviewed
Jan 25, 2021
....Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosClientContentResponseTests.cs
Show resolved
Hide resolved
ealsur
reviewed
Jan 25, 2021
kirankumarkolli
previously approved these changes
Jan 25, 2021
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
j82w
reviewed
Jan 27, 2021
....Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosClientContentResponseTests.cs
Outdated
Show resolved
Hide resolved
j82w
reviewed
Jan 27, 2021
....Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosClientContentResponseTests.cs
Outdated
Show resolved
Hide resolved
ealsur
previously approved these changes
Jan 29, 2021
There was a problem hiding this comment.
LGTM @kirankumarkolli could you verify the public API change and see if it's fine?
…ntentResponseClientBuilder
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
j82w
previously approved these changes
Feb 1, 2021
| } | ||
| } | ||
|
|
||
| if (requestOptions is TransactionalBatchItemRequestOptions batchRequestOptions) |
There was a problem hiding this comment.
Isn't the new configuration all based on ItemRequestOptions only?
There was a problem hiding this comment.
The ContentResponse flag is also available for TransactionalBatchRequestOptions
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Contracts/DotNetPreviewSDKAPI.json
Outdated
Show resolved
Hide resolved
j82w
approved these changes
Feb 2, 2021
kirankumarkolli
approved these changes
Feb 2, 2021
|
FYI Arun also signed off to include Patch. |
j82w
changed the title
j82w
changed the title
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This PR adds a new field to the CosmosClient settings to enable/disable Content Response on write operations for Documents. Currently, this needs to be configured for every item request. We can now set this when creating CosmosClient. We can also override this in ItemRequestOptions while calling any Item operation.
The issue this will close : #1917