-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gateway: Adds parallel retry logic to get account information. #2355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…educes the latency of the SDK being able to handle if there is a regional outage.
j82w
requested review from
bchong95,
ealsur,
FabianMeiswinkel,
khdang,
kirankumarkolli,
kirillg and
sboshra
as code owners
March 31, 2021 17:56
ealsur
reviewed
Mar 31, 2021
ealsur
reviewed
Apr 1, 2021
ealsur
reviewed
Apr 1, 2021
ealsur
reviewed
Apr 1, 2021
ealsur
approved these changes
Apr 1, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This reduces the time to get the account information from over 70 seconds if the primary region gateway is down to a little over 5 seconds if the user has preferred regions configured. The get account information is needed on SDK initialization and on certain failures which requires getting the updated account information to check for failovers.
Current SDK logic
Global Endpoint -> 5 sec
Global Endpoint -> 10 sec
Global Endpoint -> 20 sec
Primary Endpoint (which most of the time is the same as the global endpoint) -> 5 sec
Primary Endpoint -> 10 sec
Primary Endpoint -> 20 sec
Secondary Endpoint -> success
Total time to get the success from the secondary region is over 70 seconds + time for the secondary endpoint to respond
New SDK logic
Total time to get the success from the secondary region is 5 seconds + time for the secondary endpoint to respond
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber