Change Feed Estimator: Fixes exception propagation #2392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealsur
requested review from
FabianMeiswinkel,
j82w,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
j82w
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1830 introduced a regression on the refactoring of the Change Feed Estimator push model, where cases where the monitored or lease container did not exist were not throwing on StartAsync but rather failed and were captured during the initialization task and only surfaced when trying to StopAsync.
This PR fixes the scenario by moving the initialization back to the StartAsync flow and before the runner task is initiated.
Also improving performance by using the Cached Container Properties when initializing the lease store manager, this way if a customer is sharing the Lease Container object across many estimators/processors, we don't do another request to fetch the Partition Key (since it cannot be changed at any point).
Type of change
Closing issues
Closes #2389