Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Direct version: Adds 3.19.3 #2502

Merged
merged 5 commits into from
May 26, 2021
Merged

Direct version: Adds 3.19.3 #2502

merged 5 commits into from
May 26, 2021

Conversation

j82w
Copy link
Contributor

@j82w j82w commented May 26, 2021

Pull Request Template

Description

Commit dd6e7a19: Merged PR 574945: ClientDiagnostics: Adding TransportRequestStats class for tracking Request Timeline

RntbdRequestStats: adding timeline of events of a particular request

it adds the following Diagnostics to the StoreResult:

        "transportRequestTimeline": [
          {
            "event": "Created",
            "startTime": "2021-01-08T23:46:13.854349700Z",
            "durationInMicroSec": 198128
          },
          {
            "event": "ChannelAcquisitionStarted",
            "startTime": "2021-01-08T23:46:14.053459800Z",
            "durationInMicroSec": 696717
          },
          {
            "event": "Pipelined",
            "startTime": "2021-01-08T23:46:14.750177400Z",
            "durationInMicroSec": 175661
          },
          {
            "event": "TRANSIT TIME",
            "startTime": "2021-01-08T23:46:14.925839100Z",
            "durationInMicroSec": 76338
          },
          {
            "event": "Received",
            "startTime": "2021-01-08T23:46:15.002178Z",
            "durationInMicroSec": 103141
          },
          {
            "event": "Completed",
            "startTime": "2021-01-08T23:46:15.105319600Z",
            "durationInMicroSec": 0
          }
        ]

Commit d90fa571: Merged PR 524605: [SDK] Remove noisy trace in QuorumReader
This trace when combined with DefaultTraceListener being attached to DefaultTrace causes lock contention and high latencies on Quorum Reads.
Customers who explicitly opt out of Default Trace (including legacy GW and Compute) are unaffected but direct customers who just use the default configuration can be.

Move this trace to only log if Quorum is not met instead of every request.

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

@asketagarwal
Copy link
Contributor

Looks good to me.

@j82w j82w merged commit 72b729b into master May 26, 2021
@j82w j82w deleted the users/jawilley/direct/3.19.2 branch May 26, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants