Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Fixes incorrect order by query when the field is an object or array #2547

Merged
merged 13 commits into from
Jun 17, 2021

Conversation

kristynhamasaki
Copy link
Contributor

Pull Request Template

Description

Currently, V3 SDK hashing of object/arrays and comparisons of the hashes does not match backend behavior. This PR updates them to match.

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"

Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

@j82w j82w changed the title Update Object/Array ordering to match backend Query: Fixes Object/Array ordering to match service Jun 12, 2021
@github-actions github-actions bot dismissed their stale review June 12, 2021 00:03

All good!

@j82w j82w changed the title Query: Fixes Object/Array ordering to match service Query: Fixes incorrect order by query when the field is an object or array Jun 15, 2021
j82w
j82w previously approved these changes Jun 15, 2021
sboshra
sboshra previously approved these changes Jun 17, 2021
Copy link
Contributor

@sboshra sboshra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@sboshra sboshra merged commit 1797aaa into master Jun 17, 2021
@sboshra sboshra deleted the users/kristynh/OrderByObjectArray branch June 17, 2021 21:20
@ghost
Copy link

ghost commented Dec 15, 2021

Closing due to in-activity, pease feel free to re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants