Query: Fixes order by logic to throw original exception instead of AggregateException #2708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- pass CancellationToken to Continue to avoid start continuation if not needed - fix typo
askazakov
requested review from
j82w,
kirankumarkolli,
leminh98,
neildsh and
sboshra
as code owners
j82w
reviewed
Sep 8, 2021
.../Query/Core/Pipeline/CrossPartition/OrderBy/OrderByQueryPartitionRangePageAsyncEnumerator.cs
Outdated
Show resolved
Hide resolved
j82w
changed the title
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
j82w
reviewed
Sep 8, 2021
.../Query/Core/Pipeline/CrossPartition/OrderBy/OrderByQueryPartitionRangePageAsyncEnumerator.cs
Show resolved
Hide resolved
j82w
previously approved these changes
Sep 8, 2021
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
askazakov
requested review from
ealsur,
FabianMeiswinkel,
khdang and
kirillg
as code owners
ealsur
approved these changes
Sep 9, 2021
| TryCatch<QueryPage> monadicQueryPage = antecedent.Result; | ||
| if (monadicQueryPage.Failed) | ||
| { | ||
| Console.WriteLine(this.SqlQuerySpec); |
j82w
approved these changes
Sep 9, 2021
|
Just waiting for a fix to go in then I'll start the test run. |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
askazakov
deleted the
operation-cancelled-exception-instead-of-aggregate
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I expect OperationCancelledException not AggregateException If operation is cancelled
Type of change