Availability: Adds EnableTcpConnectionEndpointRediscovery to true by default #2724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
requested review from
ealsur,
FabianMeiswinkel,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
kirankumarkolli
previously approved these changes
Sep 10, 2021
ealsur
previously approved these changes
Sep 10, 2021
….com/Azure/azure-cosmos-dotnet-v3 into users/jawilley/ha/rediscoveryEnabled
kirankumarkolli
approved these changes
Sep 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
EnableTcpConnectionEndpointRediscovery is used to enable address cache refresh on TCP connection reset notification. By refreshing the caches it helps future requests from going to the stale addresses.
ConnectionStateListener holds a cache that maps the server physical addresses to the partitionKeyRanges(Server Key -> List[PartitionKeyRangeIdentity]). ReplicatedResourceClient updates this cache when it resolves the physical addresses for the partitions. When the listener receives a notification on connection reset from the transport client, it triggers an address refresh in the GatewayAddressCache for all the partitionKeyRanges that maps to the server address received in the notification.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber