Bulk: Adds SessionToken and ActivityId to item responses #2739
Conversation
ealsur
requested review from
FabianMeiswinkel,
j82w,
khdang,
kirankumarkolli,
kirillg,
neildsh and
sboshra
as code owners
| @@ -56,6 +56,7 @@ public async Task CreateItemStream_WithBulk() | |||
| ResponseMessage result = await task; | |||
| Assert.AreEqual(HttpStatusCode.Created, result.StatusCode); | |||
| Assert.IsTrue(result.Headers.RequestCharge > 0); | |||
| Assert.IsNotNull(result.Headers.Session); | |||
There was a problem hiding this comment.
Can we add a test that does CRUD operations with and without bulk. Then compare the headers and make sure that both have the same headers filled?
There was a problem hiding this comment.
But the headers would have different values?
There was a problem hiding this comment.
Just validate that it has the same keys in the headers. To avoid any missing headers in the future.
There was a problem hiding this comment.
They will never have the exact same headers, we are not copying the collection of headers, but individual values that make sense.
There was a problem hiding this comment.
We should still have a test to validate and prevent any new headers from getting lost. If we have known headers that we are excluding then we can just skip those headers.
ealsur
changed the title
Bulk operations, when un-packed from the Bulk response, were not wiring the Session Token and ActivityId into the respective resulting operations.
All the operations included in a Bulk response contain the same Session Token and ActivityId as they were all committed in the same transaction.
Closes #2738