Client Encryption: Adds Client Encryption APIs to GA SDK #3035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b73ed61.
anujtoshniwal
requested review from
khdang,
sboshra,
neildsh,
kirankumarkolli,
j82w,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
abhijitpai
previously approved these changes
Feb 16, 2022
kr-santosh
previously approved these changes
Feb 16, 2022
FabianMeiswinkel
requested changes
Feb 16, 2022
There was a problem hiding this comment.
We had arch board review with the Azure Central team yesterday for the Java version of the library. There was some feedback that needs further discussion with them and is relevant across Java and .Net (mostly how to expose way for crypto algorithms and how to wrap/unwrap keys) - please hold this PR until we have a clear way forward there (because it could impact public surface area)
Naveen will follow-up on this
|
Hi @FabianMeiswinkel, @j82w, @kirankumarkolli, now that the feedback has been addressed, please help review and close on this PR. Thanks! |
anujtoshniwal
dismissed stale reviews from kr-santosh and abhijitpai
via
58ae8d8
abhijitpai
previously approved these changes
Mar 8, 2022
kr-santosh
previously approved these changes
Mar 8, 2022
j82w
reviewed
Mar 9, 2022
kirankumarkolli
previously approved these changes
Mar 9, 2022
j82w
changed the title
abhijitpai
dismissed stale reviews from kirankumarkolli and kr-santosh
via
cd8ac4e
j82w
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b73ed61.
Pull Request Template
Description
Need this to GA the client-encryption feature.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber