ClientEncryption: Adds algorithm to EncryptionKeyWrapMetadata #3049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhijitpai
requested review from
khdang,
sboshra,
neildsh,
kirankumarkolli,
j82w,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
anujtoshniwal
previously approved these changes
Feb 24, 2022
j82w
reviewed
Feb 24, 2022
Microsoft.Azure.Cosmos/src/Resource/ClientEncryptionKey/EncryptionKeyWrapMetadata.cs
Show resolved
Hide resolved
j82w
reviewed
Feb 24, 2022
Microsoft.Azure.Cosmos/src/Resource/ClientEncryptionKey/EncryptionKeyWrapMetadata.cs
Show resolved
Hide resolved
…zure/azure-cosmos-dotnet-v3 into users/abpai/algoToWrapMetadata
kirankumarkolli
approved these changes
Feb 24, 2022
j82w
approved these changes
Feb 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds algorithm into the EncryptionKeyWrapMetadata to be able to save the algorithm used for key wrapping, instead of assuming a hard coded value. Saving the algorithm since it can vary is mandatory from the security perspective.
Type of change