Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AsyncCacheNonBlocking: Fixes not found error handling and task not awaited #3079

Merged
merged 4 commits into from
Mar 14, 2022
Merged

AsyncCacheNonBlocking: Fixes not found error handling and task not awaited #3079

merged 4 commits into from
Mar 14, 2022

Conversation

j82w
Copy link
Contributor

@j82w j82w commented Mar 14, 2022

Pull Request Template

Description

  1. Fixes a bug where the initial task could get stuck if the original task is never awaited.
  2. Adds the ability to only do a force refresh if the current cached value is stale. It possible another task refreshed it in the background.

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

ealsur
ealsur previously approved these changes Mar 14, 2022
View reviewed changes
Microsoft.Azure.Cosmos/src/Routing/AsyncCacheNonBlocking.cs Outdated Show resolved Hide resolved
@j82w j82w enabled auto-merge (squash) March 14, 2022 18:18
@j82w j82w merged commit a74c7bf into master Mar 14, 2022
@j82w j82w deleted the users/jawilley/ha/nonblockingCacheImprovement branch March 14, 2022 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ealsur ealsur ealsur approved these changes

@khdang khdang Awaiting requested review from khdang khdang is a code owner

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

@neildsh neildsh Awaiting requested review from neildsh neildsh is a code owner

@kirankumarkolli kirankumarkolli Awaiting requested review from kirankumarkolli kirankumarkolli is a code owner

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@j82w @ealsur