Change Feed Processor: Fixes noisy error notification when lease is stolen by other host #3124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ealsur
requested review from
khdang,
sboshra,
neildsh,
kirankumarkolli,
j82w,
FabianMeiswinkel and
kirillg
as code owners
j82w
approved these changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
During lease rebalancing, multiple hosts might try to acquire the same lease. Whoever acquires it first wins and the others get a LeaseLostException.
This LeaseLostException was getting sent through the Life Cycle Notifications and bubbled up to users unnecessarily, it is not an error or a condition they need to worry or act upon, but a normal flow of events based on the CFP design.
This PR removes the noisy notification and ensures NotifyRelease is called.