Query: Fixes "System.ArgumentException: Stream was not readable." when using WithParameterStream #3155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j82w
reviewed
Apr 22, 2022
kr-santosh
requested review from
khdang,
sboshra,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel,
kirillg and
leminh98
as code owners
abhijitpai
previously approved these changes
Apr 22, 2022
ealsur
reviewed
Apr 22, 2022
abhijitpai
approved these changes
Apr 25, 2022
j82w
approved these changes
Apr 25, 2022
j82w
changed the title
ealsur
approved these changes
Apr 27, 2022
j82w
pushed a commit
that referenced
this pull request
May 5, 2022
…n using WithParameterStream (#3155) The query definition holds the memory stream passed in by the user (this was introduced to support query on encrypted properties). That stream is then read and disposed to send the query over the wire. The issue is the query plan will be serialized multiple times for cases like cross partition queries and for scenarios where the query plan cannot be generated locally. Reserializing the query plan seems to be by design because the query plan can rewrite the query. The fix reads the stream upfront to a string which is stored and later passed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The query definition holds the memory stream passed in by the user (this was introduced to support query on encrypted properties). That stream is then read and disposed to send the query over the wire. The issue is the query plan will be serialized multiple times for cases like cross partition queries and for scenarios where the query plan cannot be generated locally. Reserializing the query plan seems to be by design because the query plan can rewrite the query.
The fix reads the stream upfront to a string which is stored and later passed.
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #3152