Diagnostics: Adds response serialization time #3165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"
Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
imanvt
changed the title
j82w
reviewed
Apr 28, 2022
Microsoft.Azure.Cosmos/src/Resource/CosmosResponseFactoryCore.cs
Outdated
Show resolved
Hide resolved
j82w
reviewed
Apr 28, 2022
Microsoft.Azure.Cosmos/src/Resource/CosmosResponseFactoryCore.cs
Outdated
Show resolved
Hide resolved
imanvt
requested review from
khdang,
sboshra,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
ealsur
reviewed
May 3, 2022
...sts/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.TypedPointOperationsAsync.xml
Outdated
Show resolved
Hide resolved
ealsur
previously approved these changes
May 3, 2022
j82w
reviewed
May 3, 2022
...EmulatorTests/BaselineTest/TestBaseline/EndToEndTraceWriterBaselineTests.ChangeFeedAsync.xml
Show resolved
Hide resolved
j82w
previously approved these changes
May 3, 2022
j82w
changed the title
j82w
reviewed
May 4, 2022
added 2 commits
May 4, 2022 17:25
…com/Azure/azure-cosmos-dotnet-v3 into users/jawilley/diagnostics/response
j82w
approved these changes
May 5, 2022
ealsur
approved these changes
May 5, 2022
j82w
pushed a commit
that referenced
this pull request
May 5, 2022
Add trace to track total serialization time in responses for additional debugging info. Fixes a bug where if a start child is called on a disposed trace which would then cause the timing to be off. It will now walk up the trace tree until it finds the active parent and add the child to that parent to keep the structure valid.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
Add trace to track total serialization time in responses for additional debugging info.
Fixes a bug where if a start child is called on a disposed trace which would then cause the timing to be off. It will now walk up the trace tree until it finds the active parent and add the child to that parent to keep the structure valid.
Type of change
Closing issues
closes #3113