Query: Adds aggressive prefetching for scalar aggregates #3168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neildsh
requested review from
khdang,
sboshra,
kirankumarkolli,
j82w,
ealsur,
FabianMeiswinkel,
kirillg and
leminh98
as code owners
neildsh
force-pushed
the
users/ndeshpan/aggressivePrefetch
branch
from
c9df9d9
to
8f42b63
Compare
j82w
reviewed
May 3, 2022
...Microsoft.Azure.Cosmos.Tests/Query/Pipeline/ParallelCrossPartitionQueryPipelineStageTests.cs
Show resolved
Hide resolved
...Microsoft.Azure.Cosmos.Tests/Query/Pipeline/ParallelCrossPartitionQueryPipelineStageTests.cs
Show resolved
Hide resolved
neildsh
force-pushed
the
users/ndeshpan/aggressivePrefetch
branch
from
8f42b63
to
c233343
Compare
ealsur
reviewed
May 4, 2022
Microsoft.Azure.Cosmos/src/Pagination/CrossPartitionRangePageAsyncEnumerator.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
May 4, 2022
Microsoft.Azure.Cosmos/src/Pagination/FullyBufferedPartitionRangeAsyncEnumerator.cs
Show resolved
Hide resolved
sboshra
reviewed
May 5, 2022
Microsoft.Azure.Cosmos/src/Pagination/FullyBufferedPartitionRangeAsyncEnumerator.cs
Outdated
Show resolved
Hide resolved
sboshra
reviewed
May 5, 2022
Microsoft.Azure.Cosmos/src/Pagination/FullyBufferedPartitionRangeAsyncEnumerator.cs
Outdated
Show resolved
Hide resolved
sboshra
reviewed
May 5, 2022
Microsoft.Azure.Cosmos/src/Pagination/FullyBufferedPartitionRangeAsyncEnumerator.cs
Outdated
Show resolved
Hide resolved
sboshra
reviewed
May 5, 2022
Microsoft.Azure.Cosmos/src/Pagination/FullyBufferedPartitionRangeAsyncEnumerator.cs
Show resolved
Hide resolved
sboshra
reviewed
May 5, 2022
Microsoft.Azure.Cosmos/src/Pagination/FullyBufferedPartitionRangeAsyncEnumerator.cs
Show resolved
Hide resolved
sboshra
reviewed
May 5, 2022
Microsoft.Azure.Cosmos/src/Query/Core/Pipeline/PipelineFactory.cs
Outdated
Show resolved
Hide resolved
sboshra
reviewed
May 5, 2022
....Cosmos/tests/Microsoft.Azure.Cosmos.Tests/Query/Pipeline/AggressivePrefetchPipelineTests.cs
Show resolved
Hide resolved
sboshra
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The query pipeline incorporates a Parallel Prefetch phase during its creation. After creation, the query pipeline runs sequentially. for scalar aggregates, we can afford to aggressively prefetch all pages, since the total memory overhead of doing so is very low.
This change implements such functionality.
Type of change