[Preview] AI Integration: Refactors code to make request object available in response object #3261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourabh1007
requested review from
kirankumarkolli,
j82w,
ealsur,
FabianMeiswinkel,
kirillg and
sboshra
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"
Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.
sourabh1007
changed the title
Microsoft.Azure.Cosmos/src/Resource/ClientEncryptionKey/ClientEncryptionKeyResponse.cs
Outdated
Show resolved
Hide resolved
Microsoft.Azure.Cosmos/src/Resource/ClientEncryptionKey/ClientEncryptionKeyResponse.cs
Show resolved
Hide resolved
sourabh1007
changed the title
sourabh1007
changed the title
ealsur
reviewed
Jun 13, 2022
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryResponse{T}.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Jun 13, 2022
Microsoft.Azure.Cosmos/src/Telemetry/OpenTelemetry/OpenTelemetryResponse.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Jun 13, 2022
ealsur
reviewed
Jun 13, 2022
Microsoft.Azure.Cosmos/src/ChangeFeedProcessor/ChangeFeedEstimatorIterator.cs
Outdated
Show resolved
Hide resolved
sourabh1007
force-pushed
the
users/sourabhjain/pointopappinsight
branch
from
722856b
to
dc5bad8
Compare
sourabh1007
changed the title
ealsur
reviewed
Jun 16, 2022
ealsur
reviewed
Jun 16, 2022
ealsur
reviewed
Jun 16, 2022
ealsur
approved these changes
Jun 20, 2022
kirankumarkolli
approved these changes
Jun 20, 2022
kirankumarkolli
pushed a commit
that referenced
this pull request
Jun 21, 2022
…able in response object (#3261) * open telemetry response support generics * typo * Include request object in response object * code refactor * add null check and make changes in encryption file * fix contract * code refactor * review pkg error for encryption * override at one more place * revert to public * contract changes * remove request message from readMany API * update documentation * requestMessage as internal * contract changes Co-authored-by: Sourabh Jain <sourabhjain@microsoft.com> Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of this PR,
OpenTelemetryResponseCorehas been created which is a parent of any kind of response in SDK. and 2 new Implementation classes are also added to make sureOpenTelemetryResponsehas all the information from the SDK response.There are 2 kind of SDK responses:
Type of change
Closing issues
To automatically close an issue: closes #IssueNumber