Draft: 3892: Adding metrics to Azure Benchmark tool #3897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-Lipin
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
M-Lipin
commented
Jun 7, 2023
| public bool WriteMetricsToConsole { get; set; } | ||
|
|
||
| [Option(Required = false, HelpText = "Application Insights instrumentation key")] | ||
| public string AppInsightsInstrumentationKey { get; set; } |
| @@ -17,9 +17,17 @@ | |||
| </None> | |||
| </ItemGroup> | |||
| <ItemGroup> | |||
| <PackageReference Include="App.Metrics" Version="4.3.0" /> | |||
There was a problem hiding this comment.
Why App.Metrics and not System.Diagnostics.Metrics?
There was a problem hiding this comment.
Can you please set-up a design review.
M-Lipin
changed the title
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3892: Adding metrics to Azure Benchmark tool
Description
This PR adds metrics collecting for Azure CosmosDB Benchmark tool. Needs to be confirmed to continue work on this with the proposed way to implement.
Type of change
Closing issues
To automatically close an issue: closes #3892