Item Operations: Fixes JsonSerialization exception when MissingMemberHandling = Error on Json default settings when NotFound on Item operations. #4125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
philipthomas-MSFT
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
philipthomas-MSFT
changed the title
philipthomas-MSFT
changed the title
…exception-instead-of-a-notfound-exception-when-jsonconvertdefaultsettingsmissingmemberhandling=error
philipthomas-MSFT
changed the title
philipthomas-MSFT
changed the title
philipthomas-MSFT
changed the title
…tead-of-a-notfound-exception-when-jsonconvertdefaultsettingsmissingmemberhandling=error' of https://github.com/Azure/azure-cosmos-dotnet-v3 into 4115-cosmos-sdk-v3-throws-a-serialization-exception-instead-of-a-notfound-exception-when-jsonconvertdefaultsettingsmissingmemberhandling=error
…exception-instead-of-a-notfound-exception-when-jsonconvertdefaultsettingsmissingmemberhandling=error
ealsur
reviewed
Oct 18, 2023
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosItemTests.cs
Outdated
Show resolved
Hide resolved
ealsur
reviewed
Oct 18, 2023
Microsoft.Azure.Cosmos/src/Resource/CosmosExceptions/CosmosExceptionFactory.cs
Show resolved
Hide resolved
ealsur
approved these changes
Oct 18, 2023
philipthomas-MSFT
changed the title
sourabh1007
approved these changes
Oct 18, 2023
…exception-instead-of-a-notfound-exception-when-jsonconvertdefaultsettingsmissingmemberhandling=error
microsoft-github-policy-service
bot
deleted the
4115-cosmos-sdk-v3-throws-a-serialization-exception-instead-of-a-notfound-exception-when-jsonconvertdefaultsettingsmissingmemberhandling=error
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
See Issue #4115
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #4115