Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Resiliency: Adds Code to Enable Advanced Replica Selection Feature for Preview and GA #4180

Conversation

kundadebdatta
Copy link
Member

@kundadebdatta kundadebdatta commented Nov 9, 2023

Pull Request Template

Description

This PR enables the Advanced Replica Selection feature for both the preview and GA packages and it is currently supported only for the Direct mode. It also introduces a new environment variable AZURE_COSMOS_REPLICA_VALIDATION_ENABLED to opt-in or opt-out the feature on demand. To understand how the environment variable is applicable for both preview and GA releases, please take a look at the table below:

Cosmos SDK Type Replica Validation Enabled By Default? Enable Replica Validation On Demand Disable Replica Validation On Demand
Preview True AZURE_COSMOS_REPLICA_VALIDATION_ENABLED = True AZURE_COSMOS_REPLICA_VALIDATION_ENABLED = False
GA True AZURE_COSMOS_REPLICA_VALIDATION_ENABLED = True AZURE_COSMOS_REPLICA_VALIDATION_ENABLED = False

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Closing issues

To automatically close an issue: closes #3922

@kundadebdatta kundadebdatta marked this pull request as ready for review November 9, 2023 22:03
@kundadebdatta kundadebdatta self-assigned this Nov 9, 2023
@kundadebdatta kundadebdatta added Upgrade Resiliency auto-merge Enables automation to merge PRs labels Nov 9, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 4fee546 into master Nov 15, 2023
21 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/kundadebdatta/3922_enable_replica_validation_in_preview branch November 15, 2023 18:15
kirankumarkolli pushed a commit that referenced this pull request Nov 15, 2023
…ature for Preview (#4180)

* Code changes to enable replica validation for preview.

* Code changes to enable replica validation for preview and GA.
microsoft-github-policy-service bot pushed a commit that referenced this pull request Nov 16, 2023
…Created vs Replaced (#4186)

* Upset status codes clarification

* Upgrade Resiliency: Adds Code to Enable Advanced Replica Selection Feature for Preview (#4180)

* Code changes to enable replica validation for preview.

* Code changes to enable replica validation for preview and GA.

---------

Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com>
@kundadebdatta kundadebdatta changed the title Upgrade Resiliency: Adds Code to Enable Advanced Replica Selection Feature for Preview Upgrade Resiliency: Adds Code to Enable Advanced Replica Selection Feature for Preview and GA Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enables automation to merge PRs Upgrade Resiliency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Cosmos Service Upgrade - .NET] Replica Validation - Expose Replica Validation Feature as a Public Contract
3 participants