Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query: Refactors Optimistic Direct Execution to be turned on by default on .NET SDK #4225

Merged

Conversation

akotalwar
Copy link
Contributor

@akotalwar akotalwar commented Dec 21, 2023

Pull Request Template

Description

Refactors Optimistic Direct Execution to be turned on by default on .NET SDK. With this change, all single partition queries will use the Optimistic Direct Execution pipeline unless specified otherwise.

Nature of the breaking change:
This change makes uses of a new type of continuation token in the SDK that not all previous version of SDK support.
As a result, when a query invoked using newer SDK version (containing this change) is invoked, the continuation token produced may not be accepted by the previous version of SDK for query continuation purposes.

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

@akotalwar akotalwar requested a review from a team as a code owner January 3, 2024 18:28
@adityasa
Copy link
Contributor

adityasa commented Jan 7, 2024

I think we should maximize the "default" behavior testing. I would be tempted to reduce the number of tests that switch off ODE explicitly in this change.
#Resolved

@neildsh
Copy link
Contributor

neildsh commented Jan 9, 2024

                queryDoc.First<Document>();

Please assert that the correct document is returned... the return value is just being thrown away here #Resolved


Refers to: Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/CosmosMultiHashTest.cs:474 in ab69838. [](commit_id = ab69838, deletion_comment = False)

@neildsh
Copy link
Contributor

neildsh commented Jan 9, 2024

This would result in loss of coverage for the regular pipelines. Perhaps it would be preferable to run the tests with ODE enabled as well as disabled?


In reply to: 1880222410

adityasa
adityasa previously approved these changes Jan 17, 2024
Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

neildsh
neildsh previously approved these changes Jan 19, 2024
@akotalwar akotalwar added auto-merge Enables automation to merge PRs QUERY labels Jan 22, 2024
Copy link
Contributor

@adityasa adityasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit e11dc9b into master Jan 24, 2024
21 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/akotalwar/TurnOnODEByDefault branch January 24, 2024 05:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enables automation to merge PRs QUERY
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants