Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK 3.37.1 : Adds version bump and changelog #4231

Merged
merged 6 commits into from
Jan 3, 2024

Conversation

NaluTripician
Copy link
Contributor

@NaluTripician NaluTripician commented Jan 2, 2024

Pull Request Template

Description

This bumps the SDK version 3.37.1. There was no changes to the GA public contract.

Preview contract changes:

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

NaluTripician and others added 2 commits January 2, 2024 14:29
* memory leak fix

* removed commented out code

* changed to async so test would pass, with just static GetPropetiesHelper will get disposed before requests go through

* added thread saftey

* fixed to interlock pattern

---------

Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com>
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@NaluTripician NaluTripician changed the title Users/nalutripician/3.37.1 SDK 3.37.1 : Adds version bump and changelog Jan 2, 2024
kundadebdatta
kundadebdatta previously approved these changes Jan 2, 2024
Copy link
Member

@kundadebdatta kundadebdatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kirankumarkolli
kirankumarkolli previously approved these changes Jan 2, 2024
@NaluTripician NaluTripician added the auto-merge Enables automation to merge PRs label Jan 2, 2024
Copy link
Member

@ealsur ealsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No code changes in version bump/release PRs

@NaluTripician NaluTripician changed the base branch from releases/3.37.1 to master January 3, 2024 15:54
changelog.md Show resolved Hide resolved
ealsur
ealsur previously approved these changes Jan 3, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 4195ec0 into master Jan 3, 2024
20 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/nalutripician/3.37.1 branch January 3, 2024 18:40
NaluTripician added a commit that referenced this pull request Jan 3, 2024
* [Internal] GlobalEndpointManager: Fixes Memory Leak (#4226)

* memory leak fix

* removed commented out code

* changed to async so test would pass, with just static GetPropetiesHelper will get disposed before requests go through

* added thread saftey

* fixed to interlock pattern

---------

Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com>

* changelog + version bump

* genAPI

* remove code changes

* removed nit

---------

Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com>
NaluTripician added a commit that referenced this pull request Jan 3, 2024
* [Internal] GlobalEndpointManager: Fixes Memory Leak (#4226)

* memory leak fix

* removed commented out code

* changed to async so test would pass, with just static GetPropetiesHelper will get disposed before requests go through

* added thread saftey

* fixed to interlock pattern

---------

Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com>

* changelog + version bump

* genAPI

* remove code changes

* removed nit

---------

Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com>
microsoft-github-policy-service bot pushed a commit that referenced this pull request Jan 3, 2024
* SDK 3.37.1 : Adds version bump and changelog (#4231)

* [Internal] GlobalEndpointManager: Fixes Memory Leak (#4226)

* memory leak fix

* removed commented out code

* changed to async so test would pass, with just static GetPropetiesHelper will get disposed before requests go through

* added thread saftey

* fixed to interlock pattern

---------

Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com>

* changelog + version bump

* genAPI

* remove code changes

* removed nit

---------

Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com>

* [Internal] GlobalEndpointManager: Fixes Memory Leak (#4226)

* memory leak fix

* removed commented out code

* changed to async so test would pass, with just static GetPropetiesHelper will get disposed before requests go through

* added thread saftey

* fixed to interlock pattern

---------

Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com>

---------

Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com>
microsoft-github-policy-service bot pushed a commit that referenced this pull request Jan 3, 2024
* SDK 3.37.1 : Adds version bump and changelog (#4231)

* [Internal] GlobalEndpointManager: Fixes Memory Leak (#4226)

* memory leak fix

* removed commented out code

* changed to async so test would pass, with just static GetPropetiesHelper will get disposed before requests go through

* added thread saftey

* fixed to interlock pattern

---------

Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com>

* changelog + version bump

* genAPI

* remove code changes

* removed nit

---------

Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com>

* [Internal] GlobalEndpointManager: Fixes Memory Leak (#4226)

* memory leak fix

* removed commented out code

* changed to async so test would pass, with just static GetPropetiesHelper will get disposed before requests go through

* added thread saftey

* fixed to interlock pattern

---------

Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com>

---------

Co-authored-by: Debdatta Kunda <87335885+kundadebdatta@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enables automation to merge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants