Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PriorityBasedExecution: Adds PriorityLevel in CosmosClientOptions #4262

Conversation

Achint-Agrawal
Copy link
Contributor

Description

Adding PriorityLevel to CosmosClientOptions to allow users to set PriorityLevel at the client level

Type of change

  • [] New feature (non-breaking change which adds functionality)
  • [] This change requires a documentation update

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the required format: "[Internal] Category: (Adds|Fixes|Refactors|Removes) Description"

Internal should be used for PRs that have no customer impact. This flag is used to help generate the changelog to know which PRs should be included. Examples:
Diagnostics: Adds GetElapsedClientLatency to CosmosDiagnostics
PartitionKey: Fixes null reference when using default(PartitionKey)
[v4] Client Encryption: Refactors code to external project
[Internal] Query: Adds code generator for CosmosNumbers for easy additions in the future.

@Achint-Agrawal Achint-Agrawal changed the title [PriorityBasedExecution] Added PriorityLevel in CosmosClientOptions [Internal] Category: (Adds) Added PriorityLevel in CosmosClientOptions Jan 18, 2024
@Achint-Agrawal Achint-Agrawal changed the title [Internal] Category: (Adds) Added PriorityLevel in CosmosClientOptions [Internal] Added PriorityLevel in CosmosClientOptions Jan 18, 2024
@Achint-Agrawal Achint-Agrawal changed the title [Internal] Added PriorityLevel in CosmosClientOptions [PriorityBasedExecution] Added PriorityLevel in CosmosClientOptions Jan 18, 2024
@Achint-Agrawal Achint-Agrawal requested a review from a team as a code owner January 24, 2024 03:54
@kirankumarkolli
Copy link
Member

/cc: @kundadebdatta ideal if we can also get this PR for 3.38 release.

ealsur
ealsur previously approved these changes Jan 30, 2024
Copy link
Member

@ealsur ealsur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some nits, I think if you use "Add suggestion to batch" from the Files view and you apply them, it would not remove the approval.

If we are pressed on time, feel free to leave it

kirankumarkolli and others added 2 commits January 30, 2024 09:52
Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com>
Co-authored-by: Matias Quaranta <ealsur@users.noreply.github.com>
@kirankumarkolli kirankumarkolli added the auto-merge Enables automation to merge PRs label Jan 30, 2024
kundadebdatta
kundadebdatta previously approved these changes Jan 30, 2024
Copy link
Member

@kundadebdatta kundadebdatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kirankumarkolli kirankumarkolli dismissed stale reviews from kundadebdatta and themself via 17ee5f7 January 30, 2024 23:49
Copy link
Member

@kundadebdatta kundadebdatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit d7a954f into master Jan 31, 2024
20 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/acagrawal/PriorityLevelInCosmosClientOptions branch January 31, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enables automation to merge PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants