Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distributed Tracing: Refactors code to rename net.peer.name attribute to server.address #4316

Merged
merged 9 commits into from Feb 13, 2024
Merged

Distributed Tracing: Refactors code to rename net.peer.name attribute to server.address #4316

merged 9 commits into from Feb 13, 2024

Conversation

sourabh1007
Copy link
Contributor

@sourabh1007 sourabh1007 commented Feb 8, 2024 •
edited

Description

Renaming net.peer.name to server.address ref. #4309

Type of change

  • [] Bug fix (non-breaking change which fixes an issue)

Closing issues

To automatically close an issue: closes #4309

kirankumarkolli
kirankumarkolli previously approved these changes Feb 9, 2024
View reviewed changes
@sourabh1007 sourabh1007 changed the title Distributed Tracing: Adds feature as stable and rename Net.Peer,Name attribute Distributed Tracing: Refactors code to rename Net.Peer,Name attribute Feb 11, 2024
@sourabh1007 sourabh1007 changed the title Distributed Tracing: Refactors code to rename Net.Peer,Name attribute Distributed Tracing: Refactors code to rename Net.Peer.Name attribute to server.address Feb 12, 2024
@sourabh1007 sourabh1007 changed the title Distributed Tracing: Refactors code to rename Net.Peer.Name attribute to server.address Distributed Tracing: Refactors code to rename net.peer.name attribute to server.address Feb 12, 2024
@sourabh1007 sourabh1007 added the auto-merge Enables automation to merge PRs label Feb 13, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit caa1aeb into master Feb 13, 2024
20 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/sourabhjain/dtattributename branch February 13, 2024 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ealsur ealsur ealsur approved these changes

@jcocchi jcocchi jcocchi left review comments

@kirankumarkolli kirankumarkolli kirankumarkolli approved these changes

@khdang khdang Awaiting requested review from khdang khdang is a code owner

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

@adityasa adityasa Awaiting requested review from adityasa adityasa is a code owner

@neildsh neildsh Awaiting requested review from neildsh neildsh is a code owner

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

Assignees
No one assigned
Labels
auto-merge Enables automation to merge PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OpenTelemetry net.peer.name attribute is out of date
4 participants
@sourabh1007 @ealsur @jcocchi @kirankumarkolli