Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Internal] Direct Package: Adds Support for Direct package version 3.33.0 #4353

Merged
merged 22 commits into from
Apr 3, 2024
Merged

[Internal] Direct Package: Adds Support for Direct package version 3.33.0 #4353

merged 22 commits into from
Apr 3, 2024

Conversation

NaluTripician
Copy link
Contributor

@NaluTripician NaluTripician commented Mar 15, 2024 •
edited

Pull Request Template

Description

Upgrades Direct package version to 3.33.0

Changes in 3.33.0

  • Bug Fixes for Fault Injection Connection Timeout Rules
  • Added TaiwanNorth and TaiwanNorthwest regions
  • Bug Fixes for Distributed Tracing

@NaluTripician NaluTripician self-assigned this Mar 15, 2024
github-actions[bot]
github-actions bot reviewed Mar 15, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@NaluTripician NaluTripician added the auto-merge Enables automation to merge PRs label Mar 15, 2024
@NaluTripician NaluTripician changed the title [Internal} Direct Package: Upgrades Direct package version to 3.33.0 [Internal} Direct Package: Adds Support for Direct package version 3.33.0 Mar 15, 2024
@NaluTripician NaluTripician changed the title [Internal} Direct Package: Adds Support for Direct package version 3.33.0 [Internal] Direct Package: Adds Support for Direct package version 3.33.0 Mar 20, 2024
@NaluTripician NaluTripician marked this pull request as ready for review March 21, 2024 21:59
@kundadebdatta
Copy link
Member

Could you please update the PR description with some of the relevant changes/ features that are actually a part of Direct 3.33.0 ?

@NaluTripician
Copy link
Contributor Author

Could you please update the PR description with some of the relevant changes/ features that are actually a part of Direct 3.33.0 ?

Updated description. @sourabh1007 can you please make sure your Distributed Tracing changes are reflected correctly.

kundadebdatta
kundadebdatta previously approved these changes Mar 21, 2024
View reviewed changes
Copy link
Member

@kundadebdatta kundadebdatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sourabh1007
Copy link
Contributor

sourabh1007 commented Mar 22, 2024 •
edited

Could you please update the PR description with some of the relevant changes/ features that are actually a part of Direct 3.33.0 ?

Updated description. @sourabh1007 can you please make sure your Distributed Tracing changes are reflected correctly.

Nothing is changed in distributed tracing, we marked n/w level telemetry stable in 3.32.1 version (which I guess never get released) and then reverted in this version of direct package. So, we don't need any changelog for this.

sourabh1007
sourabh1007 previously approved these changes Mar 23, 2024
View reviewed changes
@NaluTripician NaluTripician requested review from a team and khdang as code owners March 25, 2024 19:03
@NaluTripician
Copy link
Contributor Author

After discussion with @kundadebdatta, we decided to update the test baseline files for two tests that were failing on the CI pipeline as well as locally to move this PR forward. For one test (GroupBy), the order of the xml was moved around. For the other (NonValueAggregates), some field names were changes. These tests began failing after changing the direct package version.

@philipthomas-MSFT
Copy link
Contributor

philipthomas-MSFT commented Mar 28, 2024 •
edited

@NaluTripician Can you explain "Bug Fixes for Fault Injection Connection Timeout Rules" in detail? Is moving to 3.33.0 the fix?

@NaluTripician
Copy link
Contributor Author

@NaluTripician Can you explain "Bug Fixes for Fault Injection Connection Timeout Rules" in detail? Is moving to 3.33.0 the fix?

Yes, there were changes made in 3.33.0 that fixes behavior for connection timeout rules where some timeouts were not actually being timed out.

kundadebdatta
kundadebdatta previously approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@kundadebdatta kundadebdatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

ealsur
ealsur requested changes Apr 2, 2024
View reviewed changes
Microsoft.Azure.Cosmos/src/Regions.cs Outdated Show resolved Hide resolved
@ealsur ealsur mentioned this pull request Apr 3, 2024
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 80647ba into master Apr 3, 2024
21 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the users/nalutripician/directUpgrade3.33.0 branch April 3, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@ealsur ealsur ealsur approved these changes

@kirankumarkolli kirankumarkolli kirankumarkolli approved these changes

@sourabh1007 sourabh1007 sourabh1007 left review comments

@adityasa adityasa adityasa left review comments

@philipthomas-MSFT philipthomas-MSFT philipthomas-MSFT left review comments

@kundadebdatta kundadebdatta kundadebdatta left review comments

@FabianMeiswinkel FabianMeiswinkel Awaiting requested review from FabianMeiswinkel FabianMeiswinkel is a code owner

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

@sboshra sboshra Awaiting requested review from sboshra sboshra is a code owner

@khdang khdang Awaiting requested review from khdang khdang is a code owner

@neildsh neildsh Awaiting requested review from neildsh neildsh is a code owner

Assignees

@NaluTripician NaluTripician

Labels
auto-merge Enables automation to merge PRs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@NaluTripician @kundadebdatta @sourabh1007 @philipthomas-MSFT @ealsur @kirankumarkolli @adityasa