Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: Refactors query prefetch mechanism #4361

Merged
merged 30 commits into from
Apr 1, 2024
Merged

Performance: Refactors query prefetch mechanism #4361

Show file tree
Hide file tree
Changes from 18 commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
d005a66
sketch out improved ParallelPrefetcher; focus is on reducing allocati…
kevin-montrose Mar 14, 2024
14d5a0f
little more cleanup to further reduce allocations, and save a tiny am…
kevin-montrose Mar 15, 2024
dd7bbae
start on testing
kevin-montrose Mar 18, 2024
7032e9c
some tweaks and testing for buffer management
kevin-montrose Mar 18, 2024
6868904
test exception handling; fix a bug in high concurrency case that woul…
kevin-montrose Mar 18, 2024
7086198
test cancellation
kevin-montrose Mar 18, 2024
91eca90
more testing, a little bit of cleanup
kevin-montrose Mar 18, 2024
afe77d2
test the case where the enumerator faults; fixes a couple leaks of Ta…
kevin-montrose Mar 18, 2024
a7e0012
tiny bit of cleanup
kevin-montrose Mar 18, 2024
354b22e
cleanup and expand comments; code is tricky, it needs documentation
kevin-montrose Mar 18, 2024
e0ed9f9
address a whole bunch of style nits, just to keep compiler Message co…
kevin-montrose Mar 19, 2024
b972b0a
address some feedback on comment clarity
kevin-montrose Mar 20, 2024
8ade43b
don't rely on finalizers for testing, it's too brittle; hold up was n…
kevin-montrose Mar 20, 2024
dedbd20
complete ITrace proxy for testing
kevin-montrose Mar 20, 2024
4cdd081
style nits and a bit more commentary
kevin-montrose Mar 20, 2024
f6c3993
explicit test for concurrent access to the inner IEnumerator
kevin-montrose Mar 20, 2024
fa5b42a
explicit test that IEnumerator is disposed
kevin-montrose Mar 20, 2024
9e46e1b
explicitly implement all ITrace members
kevin-montrose Mar 20, 2024
2838a8d
Merge branch 'master' into parallelPrefetchRework
neildsh Mar 28, 2024
31cb07c
address feedback: internal class members should be public or private
kevin-montrose Mar 29, 2024
f52a737
address feedback: break test-only bits of ParallelPrefetch out into a…
kevin-montrose Mar 29, 2024
e0891fb
address feedback: move const above type declarations
kevin-montrose Mar 29, 2024
f7465e0
address feedback: naming nits
kevin-montrose Mar 29, 2024
acdb020
address feedback: use the existing NoOpTrace
kevin-montrose Mar 29, 2024
987c33d
address feedback: remove pointless using
kevin-montrose Mar 29, 2024
cc4f82d
Merge branch 'master' into parallelPrefetchRework
neildsh Mar 29, 2024
75e5d0b
Merge branch 'master' into parallelPrefetchRework
kevin-montrose Mar 29, 2024
b5d4f07
update baseline trace text for QueryAsync test
kevin-montrose Mar 29, 2024
4147878
Merge branch 'master' into parallelPrefetchRework
neildsh Apr 1, 2024
e8f0cca
Merge branch 'master' into parallelPrefetchRework
neildsh Apr 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view