Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChangeFeedProcessor: Adds AllVersionsAndDeletes support to ChangeFeedProcessor #4370

Merged

Conversation

philipthomas-MSFT
Copy link
Contributor

Pull Request Template

Description

Adding AllVersionsAndDeletes to ChangeFeedProcessor.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • [] This change requires a documentation update

Closing issues

To automatically close an issue: closes #IssueNumber

@philipthomas-MSFT philipthomas-MSFT requested a review from a team as a code owner March 25, 2024 20:43
Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the naming has been discussed before and was agreed-upon - LGTM

@philipthomas-MSFT
Copy link
Contributor Author

Given the naming has been discussed before and was agreed-upon - LGTM

Much appreciated Fabian. I will make a note to bring other SDK and Principals in on these discussions if necessary moving forward.

@philipthomas-MSFT
Copy link
Contributor Author

philipthomas-MSFT commented Mar 26, 2024

Necessary to run these locally.

dotnet.exe build Microsoft.Azure.Cosmos.sln -p:Optimize=true -p:IsPreview=true;SdkProjectRef=true
dotnet.exe build Microsoft.Azure.Cosmos.sln -p:Optimize=true -p:IsPreview=true

Both and Microsoft.Azure.Cosmos.Encryption.EncryptionContainer and Microsoft.Azure.Cosmos.Encryption.Custom.EncryptionContainer need #if SDKPROJECTREF.

Custom encryption container has throw new NotImplementedException.
Non-custom encryption container has actual implementation.

After build and merged, custom encryption container can have the actual implementation?

Copy link
Member

@FabianMeiswinkel FabianMeiswinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 71e58ee into master Mar 26, 2024
21 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot deleted the cfp__ffcf_enable_public_preview branch March 26, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge Enables automation to merge PRs dilithium-semester
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants