Query: Fixes bug in OrderByCrossPartitionQueryPipelineStage to ensure that errors in inner pipeline creation are bubbled up #4419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lures in creating the inner pipeline stage are bubbled up to the higher stages
neildsh
requested review from
khdang,
sboshra,
adityasa,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
adityasa
reviewed
Apr 15, 2024
Microsoft.Azure.Cosmos/tests/Microsoft.Azure.Cosmos.EmulatorTests/Query/OrderByQueryTests.cs
Show resolved
Hide resolved
adityasa
reviewed
Apr 15, 2024
...os/src/Query/Core/Pipeline/CrossPartition/OrderBy/OrderByCrossPartitionQueryPipelineStage.cs
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Maya-Painter
approved these changes
Apr 16, 2024
microsoft-github-policy-service
bot
deleted the
users/ndeshpan/orderByErrorReporting
branch
adityasa
pushed a commit
that referenced
this pull request
May 15, 2024
…lures in creating the inner pipeline stage are bubbled up to the higher stages (#4419)
adityasa
pushed a commit
that referenced
this pull request
May 16, 2024
…lures in creating the inner pipeline stage are bubbled up to the higher stages (#4419)
microsoft-github-policy-service bot
pushed a commit
that referenced
this pull request
May 16, 2024
…ch (#4498) * Fix bug in OrderByCrossPartitionQueryPipelineStage to ensure that failures in creating the inner pipeline stage are bubbled up to the higher stages (#4419) * Query: Fixes Persisted continuationToken issue by turning off ODE by default (#4413) * Turn of ODE by default. * Updated tests * Update * Test fix * Added test for query resumption with ODE token with partition split container (failure case). * Update. * Update Benchmark * Addressed comments. --------- Co-authored-by: neildsh <35383880+neildsh@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes bug in OrderByCrossPartitionQueryPipelineStage to ensure that errors in inner pipeline creation are bubbled up to the higher stages
Type of change