Query: Adds support for multi-value Group By query for LINQ #4481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leminh98
requested review from
khdang,
sboshra,
adityasa,
neildsh,
kirankumarkolli,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
|
Semi-related issues in case they are easy to address in the same block of work:
|
added 2 commits
May 13, 2024 15:28
adityasa
reviewed
May 16, 2024
| JOIN value IN root)) AS v2 | ||
| GROUP BY root["id"] | ||
| ]]></SqlQuery> | ||
| <ErrorMessage><![CDATA[Status Code: BadRequest,{"errors":[{"severity":"Error","location":{"start":129,"end":134},"code":"SC1001","message":"Syntax error, incorrect syntax near 'value'."}]},0x800A0B00]]></ErrorMessage> |
There was a problem hiding this comment.
This seems to indicate invalid query is being generated?
adityasa
reviewed
May 16, 2024
| <SqlQuery><![CDATA[]]></SqlQuery> | ||
| <ErrorMessage><![CDATA[Expression with NodeType 'New' is not supported.]]></ErrorMessage> | ||
| <SqlQuery><![CDATA[ | ||
| SELECT root["FamilyId"] AS familyId, ARRAY_LENGTH(root) AS familyIdCount |
adityasa
reviewed
May 16, 2024
| JOIN v2 IN root)) AS v3 | ||
| GROUP BY root["id"] | ||
| ]]></SqlQuery> | ||
| <ErrorMessage><![CDATA[Status Code: BadRequest,{"errors":[{"severity":"Error","location":{"start":7,"end":9},"code":"SC2102","message":"Property reference 'v1' is invalid in the select list because it is not contained in either an aggregate function or the GROUP BY clause."},{"severity":"Error","location":{"start":21,"end":23},"code":"SC2102","message":"Property reference 'v3' is invalid in the select list because it is not contained in either an aggregate function or the GROUP BY clause."}]},0x800A0B00]]></ErrorMessage> |
There was a problem hiding this comment.
Same as before. Seems like invalid query is being generated?
adityasa
reviewed
May 16, 2024
| ORDER BY f["FamilyId"] ASC)) AS v1 | ||
| GROUP BY root["id"] | ||
| ]]></SqlQuery> | ||
| <ErrorMessage><![CDATA[Status Code: BadRequest,{"errors":[{"severity":"Error","location":{"start":93,"end":98},"code":"SC1001","message":"Syntax error, incorrect syntax near 'value'."}]},0x800A0B00]]></ErrorMessage> |
adityasa
reviewed
May 16, 2024
...ests/BaselineTest/TestBaseline/LinqGeneralBaselineTests.TestGroupByMultiValueTranslation.xml
Show resolved
Hide resolved
adityasa
reviewed
May 16, 2024
| <SqlQuery><![CDATA[]]></SqlQuery> | ||
| <ErrorMessage><![CDATA[Expression with NodeType 'New' is not supported.]]></ErrorMessage> | ||
| <SqlQuery><
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
This PR adds the ability to translate LINQ query to SQL query with multiple items in the SQL select clause. This is achieved through the value clause using NewExpression
Type of change
Please delete options that are not relevant.
Closing issues
To automatically close an issue: closes #IssueNumber