Query: Fixes non streaming OrderByCrossPartitionQueryPipelineStage to remove state and handle splits #4493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neildsh
requested review from
adityasa,
kirankumarkolli and
sboshra
as code owners
neildsh
requested review from
khdang,
ealsur,
FabianMeiswinkel and
kirillg
as code owners
neildsh
force-pushed
the
users/ndeshpan/simplifynonStreamingOrderBy
branch
from
976be02
to
01ae3d6
Compare
sc978345
reviewed
May 16, 2024
...os/src/Query/Core/Pipeline/CrossPartition/OrderBy/OrderByCrossPartitionQueryPipelineStage.cs
Outdated
Show resolved
Hide resolved
sc978345
reviewed
May 16, 2024
...os/src/Query/Core/Pipeline/CrossPartition/OrderBy/OrderByCrossPartitionQueryPipelineStage.cs
Show resolved
Hide resolved
sc978345
reviewed
May 16, 2024
...os/src/Query/Core/Pipeline/CrossPartition/OrderBy/OrderByCrossPartitionQueryPipelineStage.cs
Outdated
Show resolved
Hide resolved
sc978345
reviewed
May 16, 2024
...os/src/Query/Core/Pipeline/CrossPartition/OrderBy/OrderByCrossPartitionQueryPipelineStage.cs
Outdated
Show resolved
Hide resolved
sc978345
reviewed
May 16, 2024
...os/src/Query/Core/Pipeline/CrossPartition/OrderBy/OrderByCrossPartitionQueryPipelineStage.cs
Show resolved
Hide resolved
sc978345
approved these changes
May 17, 2024
sboshra
approved these changes
May 17, 2024
microsoft-github-policy-service
bot
deleted the
users/ndeshpan/simplifynonStreamingOrderBy
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Simplifies
OrderByCrossPartitionQueryPipelineStageto remove state and be a static class. Since we can now statically detect no streaming order by queries, theOrderByCrossPartitionQueryPipelineStagecan be simplified considerably.We also add more handling for splits/merges for the non streaming order by pipeline stage.
Improve test coverage for split/merge handling as well as stronger validation for query charges.
Related changes:
#4362 , #4446, #4459, #4492
Type of change