Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetItemLinqQueryable now works with null query #561

Merged
merged 7 commits into from Jul 17, 2019

Conversation

j82w
Copy link
Contributor

@j82w j82w commented Jul 17, 2019

Pull Request Template

Description

GetItemLinqQueryable now correctly handles null query. This fixes a bug that caused a null reference exception.

var allObjects = this.container.GetItemLinqQueryable<ExampleObject>(true).ToList();

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Closing issues

Put closes #555

@j82w j82w added the bug Something isn't working label Jul 17, 2019
@j82w j82w self-assigned this Jul 17, 2019
@j82w j82w added this to In progress in .NET v3 Board via automation Jul 17, 2019
@j82w j82w added this to In progress in Cosmos DB SDK team via automation Jul 17, 2019
@j82w j82w requested a review from simplynaveen20 July 17, 2019 13:21
Cosmos DB SDK team automation moved this from In progress to Reviewer approved Jul 17, 2019
simplynaveen20
simplynaveen20 previously approved these changes Jul 17, 2019
.NET v3 Board automation moved this from In progress to Reviewer approved Jul 17, 2019
Cosmos DB SDK team automation moved this from Reviewer approved to Review in progress Jul 17, 2019
.NET v3 Board automation moved this from Reviewer approved to Review in progress Jul 17, 2019
Cosmos DB SDK team automation moved this from Review in progress to Reviewer approved Jul 17, 2019
Copy link
Member

@kirankumarkolli kirankumarkolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

.NET v3 Board automation moved this from Review in progress to Reviewer approved Jul 17, 2019
@kirankumarkolli kirankumarkolli merged commit fc14786 into master Jul 17, 2019
Cosmos DB SDK team automation moved this from Reviewer approved to Done Jul 17, 2019
.NET v3 Board automation moved this from Reviewer approved to Done Jul 17, 2019
@kirankumarkolli kirankumarkolli deleted the users/jawilley/linq_read_feed branch July 17, 2019 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
.NET v3 Board
  
Done
Development

Successfully merging this pull request may close these issues.

GetItemLinqQueryable throwing "Value cannot be null. Parameter name: sqlQuerySpec"
3 participants