Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug with read feed with partition key. #612

Merged
merged 5 commits into from
Aug 1, 2019

Conversation

j82w
Copy link
Contributor

@j82w j82w commented Jul 31, 2019

Pull Request Template

Description

Read feed with partition key has bug that causes it to go down the wrong pipeline which adds additional values which are not compatible with partition key. I updated the logic and added tests.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Closing issues

Put closes #610

@kirankumarkolli
Copy link
Member

ChangeLog missing

Cosmos DB SDK team automation moved this from In progress to Reviewer approved Jul 31, 2019
bchong95
bchong95 previously approved these changes Jul 31, 2019
.NET v3 Board automation moved this from In progress to Reviewer approved Jul 31, 2019
Cosmos DB SDK team automation moved this from Reviewer approved to Review in progress Jul 31, 2019
.NET v3 Board automation moved this from Reviewer approved to Review in progress Jul 31, 2019
Cosmos DB SDK team automation moved this from Review in progress to Reviewer approved Aug 1, 2019
.NET v3 Board automation moved this from Review in progress to Reviewer approved Aug 1, 2019
@kirankumarkolli kirankumarkolli merged commit d2bd043 into master Aug 1, 2019
Cosmos DB SDK team automation moved this from Reviewer approved to Done Aug 1, 2019
.NET v3 Board automation moved this from Reviewer approved to Done Aug 1, 2019
@kirankumarkolli kirankumarkolli deleted the users/jawilley/readfeed_by_partition branch August 1, 2019 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working QUERY
Projects
.NET v3 Board
  
Done
3 participants