Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding camel case serialization on LINQ query generation #716

Merged
merged 5 commits into from Aug 26, 2019

Conversation

@simplynaveen20
Copy link
Contributor

commented Aug 16, 2019

Pull Request Template

Description

This PR will help fixing issue where LINQ query generation was not entertaining the camel case option passed as serialization option during client creation.
So the item created with the camel case serialization where not able to retrieved from LINQ query.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Closing issues

#570

Note : User need to explicitly set CosmosSerializationOptions on clientOption( .WithSerializerOptions()). having PropertyNamingPolicy = CosmosPropertyNamingPolicy.CamelCase.
WithCustomSerializer() method wont work in this case.

@simplynaveen20 simplynaveen20 added the bug label Aug 16, 2019

@simplynaveen20 simplynaveen20 self-assigned this Aug 16, 2019

@simplynaveen20 simplynaveen20 added this to In progress in Cosmos DB SDK team via automation Aug 16, 2019

@kirankumarkolli kirankumarkolli requested a review from khdang Aug 20, 2019

@kirankumarkolli

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

Please get sign-off from @khdang

Cosmos DB SDK team automation moved this from In progress to Reviewer approved Aug 20, 2019

Cosmos DB SDK team automation moved this from Reviewer approved to Review in progress Aug 22, 2019

@khdang
Copy link
Member

left a comment

:shipit:

Cosmos DB SDK team automation moved this from Review in progress to Reviewer approved Aug 23, 2019

Cosmos DB SDK team automation moved this from Reviewer approved to Review in progress Aug 26, 2019

Cosmos DB SDK team automation moved this from Review in progress to Reviewer approved Aug 26, 2019

@kirankumarkolli kirankumarkolli merged commit 95763c4 into master Aug 26, 2019

5 checks passed

azure-cosmos-dotnet-v3 Build #20190826.2 succeeded
Details
azure-cosmos-dotnet-v3 (Release-$(VmImage) Microsoft.Azure.Cosmos.EmulatorTests) Release-$(VmImage) Microsoft.Azure.Cosmos.EmulatorTests succeeded
Details
azure-cosmos-dotnet-v3 (Release-$(VmImage) Microsoft.Azure.Cosmos.Tests) Release-$(VmImage) Microsoft.Azure.Cosmos.Tests succeeded
Details
azure-cosmos-dotnet-v3 (Static Analysis) Static Analysis succeeded
Details
license/cla All CLA requirements met.
Details

Cosmos DB SDK team automation moved this from Reviewer approved to Done Aug 26, 2019

@kirankumarkolli kirankumarkolli deleted the users/nakumars/camelCaseForLinq branch Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.