Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throughput fix for throwing on not found and using custom serializer #772

Merged
merged 9 commits into from
Sep 10, 2019
Merged

Throughput fix for throwing on not found and using custom serializer #772

merged 9 commits into from
Sep 10, 2019

Conversation

j82w
Copy link
Contributor

@j82w j82w commented Sep 6, 2019 •
edited
Loading

Pull Request Template

Description

Throughput operation had a bug which caused it throw when the database or container was not found.

Fixed the throughput operations to use the default property serializer instead of the customer serializer. Using the custom serializer would cause it to break based on the customer's implementation.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

closes #696 closes #728

Throughput operations no longer throw on not found, and custom serial…
1fa7610 
…izer is not applied to any throughput operation.
@j82w j82w added the bug Something isn't working label Sep 6, 2019
@j82w j82w self-assigned this Sep 6, 2019
@j82w j82w added this to In progress in .NET v3 Board via automation Sep 6, 2019
@j82w j82w added this to In progress in Cosmos DB SDK team via automation Sep 6, 2019
Cosmos DB SDK team automation moved this from In progress to Reviewer approved Sep 9, 2019
ealsur
ealsur previously approved these changes Sep 9, 2019
View reviewed changes
.NET v3 Board automation moved this from In progress to Reviewer approved Sep 9, 2019
kirankumarkolli
kirankumarkolli reviewed Sep 10, 2019
View reviewed changes
changelog.md Outdated Show resolved Hide resolved
@j82w j82w dismissed stale reviews from kirankumarkolli and ealsur via 3f9139e September 10, 2019 13:58
Cosmos DB SDK team automation moved this from Reviewer approved to Review in progress Sep 10, 2019
.NET v3 Board automation moved this from Reviewer approved to Review in progress Sep 10, 2019
Cosmos DB SDK team automation moved this from Review in progress to Reviewer approved Sep 10, 2019
.NET v3 Board automation moved this from Review in progress to Reviewer approved Sep 10, 2019
@kirankumarkolli kirankumarkolli merged commit d235751 into master Sep 10, 2019
Cosmos DB SDK team automation moved this from Reviewer approved to Done Sep 10, 2019
.NET v3 Board automation moved this from Reviewer approved to Done Sep 10, 2019
@kirankumarkolli kirankumarkolli deleted the users/jawilley/throughput_fix branch September 10, 2019 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simplynaveen20 simplynaveen20 simplynaveen20 left review comments

@kirankumarkolli kirankumarkolli kirankumarkolli approved these changes

@ealsur ealsur ealsur left review comments

@kirillg kirillg Awaiting requested review from kirillg kirillg is a code owner

Assignees

@j82w j82w

Labels
bug Something isn't working
Projects
.NET v3 Board
  
Done
Cosmos DB SDK team
  
Done
Milestone
No milestone
4 participants
@j82w @ealsur @kirankumarkolli @simplynaveen20